-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Dashboard releases #183
base: main
Are you sure you want to change the base?
Conversation
This should work after we get the change in the release-script. Now working on adding the github-action. |
hmm, its failing for me at my local desk Edit: solved by 76d2b15
|
what change do we need? script itself runs great nice job! edit: Understood, related to AlCalzone/release-script#154 @Apollon77 what do you think about the PR for release script? |
Yes and no. Only seems to run fine. Because when you look at the script you can see that the actuall running of the release script is commented out for now so that i can test the rest. If you arent in a rush to add this feature instantly i would for now jsut leave this as it is and wait a bit to see if upstream gets merged, otherwiese i could temporarily add some overidde for the upstream compile changelog-plugin. |
no rush I think the current concept and PR is the right way to go. Let's wait for feedback by maintainer of release script and follow-up. |
I dont know if its necessary to introduce another dependency as node 16 is already EOL and its run only inside the github action anyway , so the end user of the adapter does not need node18. |
Only temporary so I am also able to run it locally until my it department finally deploys 18+ 😅 |
yeah I may kind of tend to "overengineer" my contributions - sometimes simple bugs led me to things that i think can be improved and then it may escalate a bit :D. Had I similar journey a few months ago where another project had a dependency that updated which broke a template because the dependency changed from a default export to a named one. |
Well... Good that I have root / sudo access to all of my devices 😄 maybe just leave it in your test-branch and don't fully merge it in, so the "temporary" don't get quite permanent because we forget about it. also speaking of forgetting about it, after having it running once we hopefully don't have to touch it / run locally to test again and everything just works and updates the dashboard from time to time automagically 😄 |
@DutchmanNL |
Fixes #118