This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Add properties to TokenIntrospectionResponse for all optional claims defined in RFC 7662 (OAuth 2.0 Token Introspection) #577
+180
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xced
force-pushed
the
TokenIntrospectionResponseAdditions
branch
from
3d72d7f to
b6315d7
Compare
|
#576 has been merged. Could you kindly rebase this PR? Thx. |
We'll look to have it in by early next week (pending a rebase). |
0xced
force-pushed
the
TokenIntrospectionResponseAdditions
branch
from
b6315d7 to
70b64f9
Compare
|
It's rebased. Thanks for merging my other pull requets! |
josephdecock
reviewed
Oct 8, 2024
There was a problem hiding this comment.
I think it's probably a good idea to model the optional claims from the spec like this, but I think if we're going to do that, we should do all of the claims listed here.
|
Good point. Should I implement the additional properties as part of this pull request or should it be done in a followup pull request? |
0xced
force-pushed
the
TokenIntrospectionResponseAdditions
branch
from
70b64f9 to
738ceff
Compare
0xced
changed the title
|
I went ahead and implemented properties for all optional claims defined in RFC 7662. |
0xced
force-pushed
the
TokenIntrospectionResponseAdditions
branch
4 times, most recently
from
3822fe2 to
7f53cf1
Compare
As described by [RFC 7662 - OAuth 2.0 Token Introspection][1] [1]: https://datatracker.ietf.org/doc/html/rfc7662
0xced
force-pushed
the
TokenIntrospectionResponseAdditions
branch
from
7f53cf1 to
6e089e7
Compare
|
This PR has been migrated to DuendeSoftware/foss#98 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by RFC 7662 - OAuth 2.0 Token Introspection
Note
This pull request is stacked on top of #576