This repository has been archived by the owner on Feb 11, 2025. It is now read-only.
Fix HttpClientExtensions to dispose of HttpResponseMessage when it goes out of scope #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gizmohd, thanks for your contribution. The PR looks reasonable. We're now maintaining |
|
you can manually copy the changes over if you wish.
…On Sun, Nov 17, 2024 at 2:55 PM Damian Hickey ***@***.***> wrote:
Hi @gizmohd <https://github.com/gizmohd>, thanks for your contribution.
The PR looks reasonable.
We're now maintaining IdentityModel as Duende.IdentityModel in this
repository
<https://github.com/DuendeSoftware/foss/tree/main/identity-model>. I can
either manually copy your changes over, or, if you want your name on the
commit you can resubmit over there? Up to yourself.
—
Reply to this email directly, view it on GitHub
<#598 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMWIDM5ITDOWGTSPPUDB532BDYBXAVCNFSM6AAAAABQYEDQCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGUYDCOBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
damianh
added a commit
to DuendeSoftware/foss
that referenced
this pull request
Feb 10, 2025
|
Migrated to DuendeSoftware/foss#95 |
damianh
added a commit
to DuendeSoftware/foss
that referenced
this pull request
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HttpClientExtensions to dispose of HttpResponseMessage when it goes out of scope to resolve a memory leak because the response objects are not getting disposed of on time.
Some applications are very chatty and when that happens GC may not clean up all the objects on time.