Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove csquery package refrence and unused code #213

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

damianh
Copy link
Member

@damianh damianh commented Dec 1, 2024

Removes CSQuery package reference fixing several compilation warnings regarding vulnerable transitive dependencies. Even though it was referenced in a test project. Also, CSQuery is not maintained.

Removed all code using CSQuery as none of it was used on any test path.

If we need HTML parsing in the future, we'll introduce AngleSharp.

@damianh damianh self-assigned this Dec 1, 2024
@damianh damianh requested a review from josephdecock December 1, 2024 19:59
@damianh damianh force-pushed the dh/remove-cs-query branch from a11634a to 346c232 Compare December 1, 2024 19:59
@josephdecock
Copy link
Member

Awesome - I did the same thing and actually introduced AngleSharp somewhere else a while back (maybe it was AccesTokenManagement?)

@josephdecock josephdecock merged commit 0908510 into DuendeSoftware:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants