Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13, use validated principal claims #14

Closed
wants to merge 2 commits into from

Conversation

jpda
Copy link

@jpda jpda commented Dec 10, 2024

See #13, uses claims from the validated token principal instead of the raw AT claims.

@josephdecock
Copy link
Member

Thanks for this suggestion, and sorry we left you hanging for a month! I think it's a great idea, and I think we can even go a step further. I don't think there's any reason for us to parse the token at all, since the JWT Bearer handler is going to parse it already and put the results into the principal. We're not using the results of parsing for anything except getting the token, so we can avoid instantiating the JsonWebTokenHandler and then doing the work of parsing the token.

There is no need to parse the access token in the DPoPJwtBearerEvents, since the handler already parses and makes the claims available in the context.
@josephdecock
Copy link
Member

This build is failing because of other pipeline issues. Hopefully when #18 lands, this will work.

@josephdecock
Copy link
Member

I went ahead and rebased this on to main (where we have the latest changes that fix the CI pipeline), so I've created a new branch and a new PR. I'm going to close this in favor of #19, but nonetheless, Thank You Very Much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants