Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Duende.IdentityModel #16

Closed

Conversation

twenzel
Copy link
Contributor

@twenzel twenzel commented Jan 15, 2025

@josephdecock
Copy link
Member

josephdecock commented Jan 20, 2025

Thanks for this PR! There's a few changes to the dependencies that I want to make. While I would generally like to take the latest version of packages, especially when writing application code, our experience has been that taking a lower version is usually better, because in a nuget package, the dependency that we take establishes the minimum version, and anyone can go higher than that. That means that every time we update a dependency, that makes our requirements more restrictive, and sometimes there are weird incompatibilities (notably with System.IdentityModel) and by putting the fewest constraints in place as possible, we generally see fewer problems. I'm also going to rebase this onto main, as there have been some updates to the CI pipeline that are required to build in the last couple days.

@josephdecock
Copy link
Member

I'm going to close this PR and open a new one, rebased onto main, just because we need the latest from main to build. Thanks very much for the PR!

@twenzel twenzel deleted the feature/UpdateIdentityModel branch January 21, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Duende.IdentityModel
2 participants