Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate access token parsing #19

Merged
merged 2 commits into from
Jan 21, 2025
+1 −6
Merged

Avoid duplicate access token parsing #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf9357
#13, use validated principal claims
jpda Dec 10, 2024
d6ff003
Avoid extra parse of access token
josephdecock Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/AspNetCore.Authentication.JwtBearer/DPoP/DPoPJwtBearerEvents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using Microsoft.IdentityModel.JsonWebTokens;
using Microsoft.Net.Http.Headers;
using static IdentityModel.OidcConstants;

Expand Down Expand Up @@ -73,16 +72,12 @@ public override async Task TokenValidated(TokenValidatedContext context)
throw new InvalidOperationException("Missing DPoP (proof token) HTTP header");
}

// TODO - Add support for introspection
var handler = new JsonWebTokenHandler();
var parsedToken = handler.ReadJsonWebToken(at);

var result = await _validator.Validate(new DPoPProofValidationContext
{
Scheme = context.Scheme.Name,
ProofToken = proofToken,
AccessToken = at,
AccessTokenClaims = parsedToken?.Claims ?? [],
AccessTokenClaims = context.Principal?.Claims ?? [],
Method = context.HttpContext.Request.Method,
Url = context.HttpContext.Request.Scheme + "://" + context.HttpContext.Request.Host + context.HttpContext.Request.PathBase + context.HttpContext.Request.Path
});
Expand Down
Loading