Skip to content

Commit

Permalink
Merge pull request #1738 from Erwinvandervalk/bff-async-DefaultUserSe…
Browse files Browse the repository at this point in the history
…rvice

bff - Make user service methods async
  • Loading branch information
Erwinvandervalk authored Jan 29, 2025
2 parents b4daf0a + 40c87cd commit 0ec1f90
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions bff/src/Duende.Bff/EndpointServices/User/DefaultUserService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public virtual async Task ProcessRequestAsync(HttpContext context)
else
{
var claims = new List<ClaimRecord>();
claims.AddRange(GetUserClaims(result));
claims.AddRange(GetManagementClaims(context, result));
claims.AddRange(await GetUserClaimsAsync(result));
claims.AddRange(await GetManagementClaimsAsync(context, result));

var json = JsonSerializer.Serialize(claims);

Expand All @@ -90,9 +90,9 @@ public virtual async Task ProcessRequestAsync(HttpContext context)
/// </summary>
/// <param name="authenticateResult"></param>
/// <returns></returns>
protected virtual IEnumerable<ClaimRecord> GetUserClaims(AuthenticateResult authenticateResult)
protected virtual Task<IEnumerable<ClaimRecord>> GetUserClaimsAsync(AuthenticateResult authenticateResult)
{
return authenticateResult.Principal?.Claims.Select(x => new ClaimRecord(x.Type, x.Value)) ?? Enumerable.Empty<ClaimRecord>();
return Task.FromResult(authenticateResult.Principal?.Claims.Select(x => new ClaimRecord(x.Type, x.Value)) ?? Enumerable.Empty<ClaimRecord>());
}

/// <summary>
Expand All @@ -101,7 +101,7 @@ protected virtual IEnumerable<ClaimRecord> GetUserClaims(AuthenticateResult auth
/// <param name="context"></param>
/// <param name="authenticateResult"></param>
/// <returns></returns>
protected virtual IEnumerable<ClaimRecord> GetManagementClaims(HttpContext context, AuthenticateResult authenticateResult)
protected virtual Task<IEnumerable<ClaimRecord>> GetManagementClaimsAsync(HttpContext context, AuthenticateResult authenticateResult)
{
var claims = new List<ClaimRecord>();

Expand Down Expand Up @@ -132,7 +132,7 @@ protected virtual IEnumerable<ClaimRecord> GetManagementClaims(HttpContext conte
}
}

return claims;
return Task.FromResult((IEnumerable<ClaimRecord>)claims);
}

/// <summary>
Expand Down

0 comments on commit 0ec1f90

Please sign in to comment.