Merge pull request #1741 from DuendeSoftware/bff-sample-links

Update links and add alt attribute in Index page
DuendeSoftware · Jan 30, 2025 · a1d3784 · a1d3784
2 parents b2bce6e + 7addafb
commit a1d3784
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/bff/samples/IdentityServer/Pages/Index.cshtml b/bff/samples/IdentityServer/Pages/Index.cshtml
@@ -3,25 +3,25 @@
 
 <div class="welcome-page">
     <h1>
-        <img src="~/duende-logo.svg" class="logo">
+        <img alt="Duende Logo" src="~/duende-logo.svg" class="logo">
         Welcome to Duende IdentityServer
         <small class="text-muted">(version @Model.Version)</small>
     </h1>
 
     <ul>
         <li>
             IdentityServer publishes a
-            <a href="~/.well-known/openid-configuration">discovery document</a>
+            <a href="@Url.Content("~/.well-known/openid-configuration")">discovery document</a>
             where you can find metadata and links to all the endpoints, key material, etc.
         </li>
         <li>
-            Click <a href="~/diagnostics">here</a> to see the claims for your current session.
+            Click <a asp-page="/Diagnostics/Index">here</a> to see the claims for your current session.
         </li>
         <li>
-            Click <a href="~/grants">here</a> to manage your stored grants.
+            Click <a asp-page="/Grants/Index">here</a> to manage your stored grants.
         </li>
         <li>
-            Click <a href="~/ciba/all">here</a> to view your pending CIBA login requests.
+            Click <a asp-page="/Ciba/All">here</a> to view your pending CIBA login requests.
         </li>
         <li>
             Here are links to the

diff --git a/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs b/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
@@ -7,8 +7,11 @@
 
 namespace Duende.Bff.Tests.TestFramework
 {
-    public class TestLoggerProvider(WriteTestOutput? writeOutput = null, string? name = null) : ILoggerProvider
+    public class TestLoggerProvider(WriteTestOutput writeOutput, string name) : ILoggerProvider
     {
+        private readonly WriteTestOutput _writeOutput = writeOutput ?? throw new ArgumentNullException(nameof(writeOutput));
+        private readonly string _name = name ?? throw new ArgumentNullException(nameof(name));
+
         public class DebugLogger : ILogger, IDisposable
         {
             private readonly TestLoggerProvider _parent;
@@ -41,11 +44,11 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
             }
         }
 
-        public List<string> LogEntries = new List<string>();
+        public List<string> LogEntries { get; } = new();
 
         private void Log(string msg)
         {
-            writeOutput?.Invoke(name + msg);
+            _writeOutput?.Invoke(_name + msg);
             LogEntries.Add(msg);
         }