Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to .NET RC.2 #1448

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Update to .NET RC.2 #1448

merged 4 commits into from
Oct 25, 2023

Conversation

leastprivilege
Copy link
Member

@leastprivilege leastprivilege commented Oct 24, 2023 •
edited
Loading

..new warnings and new failed tests around JWTs... could you please have a look @josephdecock

@josephdecock josephdecock marked this pull request as ready for review October 25, 2023 15:26
josephdecock
josephdecock requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there are still some warnings to address...

josephdecock
josephdecock approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, warnings are fixed now too

@josephdecock josephdecock merged commit be9ce62 into main Oct 25, 2023
5 checks passed
@josephdecock josephdecock deleted the dom/update-to-net8-rc2 branch October 25, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephdecock josephdecock josephdecock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leastprivilege @josephdecock