Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for IdentityServerTools #1454

Merged
merged 4 commits into from
Nov 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 5 additions & 32 deletions src/IdentityServer/IdentityServerTools.cs
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
namespace Duende.IdentityServer;

/// <summary>
/// Class for useful helpers for interacting with IdentityServer
/// Useful helpers for interacting with IdentityServer.
/// </summary>
public interface IIdentityServerTools
{
@@ -61,13 +61,7 @@ public class IdentityServerTools : IIdentityServerTools
private readonly ITokenCreationService _tokenCreation;
private readonly IClock _clock;

/// <summary>
/// Initializes a new instance of the <see cref="IdentityServerTools" /> class.
/// </summary>
/// <param name="serviceProvider">The provider.</param>
/// <param name="issuerNameService">The issuer name service</param>
/// <param name="tokenCreation">The token creation service.</param>
/// <param name="clock">The clock.</param>
/// <inheritdoc/>
public IdentityServerTools(IServiceProvider serviceProvider, IIssuerNameService issuerNameService, ITokenCreationService tokenCreation, IClock clock)
{
ServiceProvider = serviceProvider;
@@ -76,42 +70,21 @@ public IdentityServerTools(IServiceProvider serviceProvider, IIssuerNameService
_clock = clock;
}

/// <summary>
/// Issues a JWT.
/// </summary>
/// <param name="lifetime">The lifetime.</param>
/// <param name="claims">The claims.</param>
/// <returns></returns>
/// <exception cref="System.ArgumentNullException">claims</exception>
/// <inheritdoc/>
public virtual async Task<string> IssueJwtAsync(int lifetime, IEnumerable<Claim> claims)
{
var issuer = await IssuerNameService.GetCurrentAsync();
return await IssueJwtAsync(lifetime, issuer, claims);
}

/// <summary>
/// Issues a JWT.
/// </summary>
/// <param name="lifetime">The lifetime.</param>
/// <param name="issuer">The issuer.</param>
/// <param name="claims">The claims.</param>
/// <returns></returns>
/// <exception cref="System.ArgumentNullException">claims</exception>
/// <inheritdoc/>
public virtual Task<string> IssueJwtAsync(int lifetime, string issuer, IEnumerable<Claim> claims)
{
var tokenType = OidcConstants.TokenTypes.AccessToken;
return IssueJwtAsync(lifetime, issuer, tokenType, claims);
}

/// <summary>
/// Issues a JWT.
/// </summary>
/// <param name="lifetime">The lifetime.</param>
/// <param name="issuer">The issuer.</param>
/// <param name="tokenType"></param>
/// <param name="claims">The claims.</param>
/// <returns></returns>
/// <exception cref="System.ArgumentNullException">claims</exception>
/// <inheritdoc/>
public virtual async Task<string> IssueJwtAsync(int lifetime, string issuer, string tokenType, IEnumerable<Claim> claims)
{
if (String.IsNullOrWhiteSpace(issuer)) throw new ArgumentNullException(nameof(issuer));