Cleanup deprecated code and TODOs #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
josephdecock
commented
Nov 1, 2023
•
josephdecock
commented
- Remove code marked as unused/to be removed in 7.0
- Fix typo in name
- Clean up some very old todos that don't need to be done anymore
- Remove code marked as unused/to be removed in 7.0 - Fix typo in name - Clean up some very old todos that don't need to be done anymore
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
brockallen
reviewed
Nov 2, 2023
| @@ -6,6 +6,6 @@ namespace Duende.IdentityServer; | |||
|
|
|||
| internal static class Constants | |||
| { | |||
| public const string IdentityServerName = "IdentityServer4"; | |||
| public const string IdentityServerName = "Duende.IdentityServer"; | |||
There was a problem hiding this comment.
where is this used? will this change cause any breaking changes?
There was a problem hiding this comment.
I don't think this is likely to break anyone. It is used
- As the default value for the CorsPolicyName option and
- As the value for IdentityServerAuthenticationType
I guess theoretically if someone has created a cors policy and named it "Duende.IdentityServer", this conflicts with that. That seems pretty unlikely to me.
And theoretically, a customer could have a customization that cares about the authentication type and refers to it without using this constant. Again, seems pretty unlikely.
OTOH, this is a low-value change.
brockallen
approved these changes
Nov 3, 2023
This was referenced Nov 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.