i#2626 AArch64 encoder: Fix comment. (#3014)

Address feedback from #3011
DynamoRIO · May 18, 2018 · 93d61b5 · 93d61b5
1 parent ef52597
commit 93d61b5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/core/arch/aarch64/encode.c b/core/arch/aarch64/encode.c
@@ -132,7 +132,7 @@ encoding_possible(decode_info_t *di, instr_t *in, const instr_info_t * ii)
 {
     uint enc;
 
-    byte tmp[4];
+    byte tmp[AARCH64_INSTR_SIZE];
     enc = encode_common(&tmp[0], in, di);
     return enc != ENCFAIL;
 }

diff --git a/core/arch/arch_exports.h b/core/arch/arch_exports.h
@@ -1922,11 +1922,13 @@ set_reached_image_entry(void);
 /* in encode.c */
 /* DR_API EXPORT TOFILE dr_ir_instr.h */
 DR_API
-/** Returns true iff \p instr can be encoded as
+/**
+ * Returns true iff \p instr can be encoded as
  *    - a valid IA-32 instruction on X86
  *    - a valid Armv8-a instruction on AArch64 (Note: The AArch64 encoder/decoder is
  *      not complete yet, so DynamoRIO may fail to encode some valid Armv8-a
- *      instructions. See i#2626)
+ *      instructions)
+ *    - a valid Armv7 instruction on ARM
  */
 bool
 instr_is_encoding_possible(instr_t *instr);