i#3346 trace exit: avoid deadlock in check_in_last_thread_vm_area #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the lock acquisition from check_in_last_thread_vm_area to avoid deadlock. The scenario we're trying to catch will read and match with no extra lock due to the bb building lock. It would be nice to have a test but it is not easy to write due to the race that needs to be arranged. Issue: #3346
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the lock acquisition from check_in_last_thread_vm_area to
avoid deadlock. The scenario we're trying to catch will read and
match with no extra lock due to the bb building lock.
It would be nice to have a test but it is not easy to write due to the
race that needs to be arranged.
Issue: #3346