i#6953: Fix sigcontext test AVX error #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces a kill() with an inlined system call in the linux.sigcontext test to avoid failure when compiled for AVX only, as the compiler inserts VZEROUPPER there. Tested on a toolchain targeting AVX. Fixes #6953
|
These arm runs seem to have a failing test every single PR now. This one is the drstatecmp-fuzz timeout #6944. |
edeiana
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces a kill() with an inlined system call in the linux.sigcontext test to avoid failure when compiled for AVX only, as the compiler inserts VZEROUPPER there (VZEROUPPER is recommended by Intel to avoid a performance penalty when switching between upper-zeroing VEX-encoded XMM operations and legacy upper-preserving SSE* operations: so doing it at transitions to code you don't control makes sense).
Tested on a toolchain targeting AVX.
Fixes #6953