i#7044 hang: Sleep on wait in parallel drmemtrace analyzer #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a 1ms sleep on a STATUS_WAIT in the drmemtrace analyzer when operating in parallel. This avoids costly spinning in replay mode. Adding targeted condition variables inside the scheduler doesn't end up performing any better and is complicated by the scheduler not knowing the threading model of the user, so this is a safer and simpler solution despite not waiting on an event. Fixes #7044
abhinav92003
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 1ms sleep on a STATUS_WAIT in the drmemtrace analyzer when operating in parallel. This avoids costly spinning in replay mode. Adding targeted condition variables inside the scheduler doesn't end up performing any better and is complicated by the scheduler not knowing the threading model of the user, so this is a safer and simpler solution despite not waiting on an event.
Tested on a medium-large internal trace where the spinning makes replaying as-traced take 7:35; with the sleep it takes 1:15.
Fixes #7044