Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5383: Fix macOS preload on a64 #7170

Merged
merged 21 commits into from
Jan 16, 2025
Merged

i#5383: Fix macOS preload on a64 #7170

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3f6df3a
i#5383: Fix macOS hello world on a64
ndrewh Aug 19, 2024
2bef5e1
Move proc_set_feature back to outside ifdefs
ndrewh Dec 26, 2024
42a70c3
clang-format
ndrewh Dec 26, 2024
5e9052d
only disable PLATFORM_SUPPORTS_SCATTER_GATHER on macOS arm64
ndrewh Dec 26, 2024
0b572c2
format
ndrewh Dec 27, 2024
7ab41d3
idk why these changes are here; it builds fine without them?
ndrewh Dec 27, 2024
2151321
clean
ndrewh Dec 27, 2024
b403254
sanity check
ndrewh Dec 27, 2024
c5a1cef
Add __attribute__((constructor)) to macos builds for _init
ndrewh Dec 27, 2024
12c04bd
clang-format is going insane
ndrewh Dec 27, 2024
a4c71c2
sanity
ndrewh Dec 27, 2024
e95e36a
only add the attribute on aarch64, i guess
ndrewh Dec 27, 2024
c2d86aa
clang-format (i dont wanna install it on macos lol)
ndrewh Dec 27, 2024
1fdc8b1
Improve comments, more generic sysctl macro
ndrewh Jan 4, 2025
5a45c1b
clang-format
ndrewh Jan 4, 2025
c557d23
nits
ndrewh Jan 10, 2025
7498a10
clang-format
ndrewh Jan 10, 2025
cc08e6b
Merge branch 'master' into i5383-macos-14-4-preload
ndrewh Jan 10, 2025
3575190
add check for ARM_NEON64
ndrewh Jan 11, 2025
5a72ccc
Merge branch 'master' into i5383-macos-14-4-preload
ndrewh Jan 14, 2025
3ac322a
Merge branch 'master' into i5383-macos-14-4-preload
edeiana Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/unix/signal_macos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,16 @@ sigcontext_to_mcontext_simd(priv_mcontext_t *mc, sig_full_cxt_t *sc_full)
return;
mc->fpsr = fpc->__fpsr;
mc->fpcr = fpc->__fpcr;
for (int i = 0; i < proc_num_simd_registers(); i++) {
memcpy(&mc->simd[i].q, &fpc->__v[i], sizeof(mc->simd->q));
if (proc_has_feature(FEATURE_SVE)) {
/* XXX i#5383: SVE and SVE2 support for MACOS still missing.
*/
ASSERT_NOT_IMPLEMENTED(false);
ndrewh marked this conversation as resolved.
Show resolved Hide resolved
} else {
/* ARM_NEON64 case.
*/
for (int i = 0; i < proc_num_simd_registers(); i++) {
memcpy(&mc->simd[i].q, &fpc->__v[i], sizeof(mc->simd->q));
}
}
#elif defined(X86)
/* We assume that _STRUCT_X86_FLOAT_STATE* matches exactly the first
Expand Down
Loading