fixup! fix(download): Escape all Go templating expressions after down…

…loading

internal/template/escape.go

@@ -20,10 +20,9 @@ import (
 	"bytes"
 )
 
-// EscapeGoTemplating replaces each occurrence of "{{" with "{{`{{`}}" and each occurrence of "}}" with "{{`}}`}}".
-// Go templating uses `{{` and `}}` to delimit	 "actions" like data evaluation and control structures. See [text/template] for further details.
-// This is used for both Jinja expressions that resources like Workflows use, but also occurrences in DQL queries and other places.
-func EscapeGoTemplating(src []byte) []byte {
+// UseGoTemplatesForDoubleCurlyBraces replaces each occurrence of "{{" with "{{`{{`}}" and each occurrence of "}}" with "{{`}}`}}".
+// This ensures that when the returned string is used to render templates, e.g. during deployment, the "{{" and "}}" are not misinterpreted.
+func UseGoTemplatesForDoubleCurlyBraces(src []byte) []byte {
 	src = bytes.ReplaceAll(src, []byte("{{"), []byte("{{`{{`")) // replace is divided in 2 steps to avoid replacing of closing brackets in the next step
 	src = bytes.ReplaceAll(src, []byte("}}"), []byte("{{`}}`}}"))
 	src = bytes.ReplaceAll(src, []byte("{{`{{`"), []byte("{{`{{`}}"))

internal/template/escape_test.go

@@ -76,7 +76,7 @@ func TestEscapeGoTemplating(t *testing.T) {
 
 	for _, tt := range tc {
 		t.Run(tt.in, func(t *testing.T) {
-			out := EscapeGoTemplating([]byte(tt.in))
+			out := UseGoTemplatesForDoubleCurlyBraces([]byte(tt.in))
 
 			assert.Equal(t, tt.expected, string(out))
 		})