feat(segments): deploy support for segments API
#1660
+732
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomazpu
added
run-e2e-test
E2E Test Results 4 files - 1 272 suites - 132 33s ⏱️ - 1h 12m 2s For more details on these failures, see this check. Results for commit 4c12790. ± Comparison against base commit 74698e1. This pull request removes 644 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Unit Test Results1 985 tests +13 1 984 ✅ +13 54s ⏱️ ±0s Results for commit 2d7baa2. ± Comparison against base commit 5beebaf. This pull request removes 4 and adds 17 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tomazpu
force-pushed
the
feat/GFF/deploy
branch
5 times, most recently
from
05a94e6 to
a3f5d09
Compare
tomazpu
force-pushed
the
feat/GFF/deploy
branch
from
45559e8 to
fbece18
Compare
Laubi
requested changes
Jan 13, 2025
tomazpu
force-pushed
the
feat/GFF/deploy
branch
from
ae789f7 to
c1acc5b
Compare
Laubi
previously approved these changes
Jan 22, 2025
…in delete_test.go
tomazpu
force-pushed
the
feat/GFF/deploy
branch
from
c1acc5b to
25a2958
Compare
jskelin
reviewed
Jan 23, 2025
| err := delete.Configs(context.TODO(), client.ClientSet{SegmentClient: &c}, given) | ||
| assert.NoError(t, err) | ||
| assert.True(t, c.called, "delete should have been called") | ||
| //DummyClient returns unimplemented error on every execution of any method |
There was a problem hiding this comment.
I think we need to update this too:
Suggested change
| //DummyClient returns unimplemented error on every execution of any method | |
| // fakeClient returns unimplemented error on every execution of any method |
pkg/delete/delete_test.go
Outdated
|
|
||
| err := delete.All(context.TODO(), client.ClientSet{SegmentClient: &c}, api.APIs{}) | ||
| assert.NoError(t, err) | ||
| assert.True(t, c.called, "delete should have been called") | ||
| //Dummy client returns unimplemented error on every execution of any method |
There was a problem hiding this comment.
Suggested change
| //Dummy client returns unimplemented error on every execution of any method | |
| // fakeClient returns unimplemented error on every execution of any method |
|
Laubi
approved these changes
Jan 23, 2025
|
|
||
| id, err := deployWithOriginObjectId(ctx, client, c, requestPayload) | ||
| if err != nil { | ||
| return entities.ResolvedEntity{}, fmt.Errorf("failed to deploy segment with externalId: %s : %w", externalId, err) |
There was a problem hiding this comment.
Is this error message correct? Or should it reference originObjectId?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
This PR adds support for the
segmentsAPI in monaco.Special notes for your reviewer:
Follow-up is planned to move the logic of adding
uidandownerto the lib.Does this PR introduce a user-facing change?