Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documents): Support Launchpad documents #1671

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

Laubi
Copy link
Contributor

@Laubi Laubi commented Jan 16, 2025

What this PR does / Why we need it:

This change allows users to download and deploy Dynatrace Launchpad documents.

Example:

configs:
- id: my-launchpad
  type:
    document:
      kind: launchpad
  config:
    name: My super awesome launchpad!
    template: './my-launchpad.json'

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes: Users can now define Launchpad documents

Copy link

github-actions bot commented Jan 16, 2025

Unit Test Results

1 964 tests  ±0   1 963 ✅ ±0   54s ⏱️ ±0s
  135 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit aa6ed45. ± Comparison against base commit e8c4e07.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/download_dashboard_and_notebook_documents_works
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/notebook_download_still_works_if_dashboard_download_fails
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/download_of_all_document_kinds_in_one_go_works
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/other_documents_are_written_even_if_one_fails

♻️ This comment has been updated with latest results.

@Laubi Laubi force-pushed the feat/documents-launchpad branch from 3f54fc6 to 282b1ed Compare January 16, 2025 12:28
This change allows users to download and deploy Dynatrace Launchpad documents.
@Laubi Laubi force-pushed the feat/documents-launchpad branch from 282b1ed to 8e21e1e Compare January 16, 2025 12:31
@Laubi Laubi marked this pull request as ready for review January 16, 2025 12:36
@Laubi Laubi requested a review from a team as a code owner January 16, 2025 12:36
@Laubi Laubi added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Jan 16, 2025
@Laubi Laubi self-assigned this Jan 16, 2025
Copy link

E2E Test Results

    4 files   -   1    272 suites   - 135   27m 29s ⏱️ - 1h 0m 38s
2 083 tests  -   2  2 081 ✅  -   2  2 💤 ±0  0 ❌ ±0 
2 235 runs   - 154  2 233 ✅  - 154  2 💤 ±0  0 ❌ ±0 

Results for commit 21003e0. ± Comparison against base commit e8c4e07.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/download_dashboard_and_notebook_documents_works
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/notebook_download_still_works_if_dashboard_download_fails
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/download_of_all_document_kinds_in_one_go_works
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/document ‑ TestDownloader_Download/other_documents_are_written_even_if_one_fails

@Laubi Laubi force-pushed the feat/documents-launchpad branch from 21003e0 to aa6ed45 Compare January 16, 2025 14:38
@Laubi Laubi merged commit 3290212 into main Jan 16, 2025
12 checks passed
@Laubi Laubi deleted the feat/documents-launchpad branch January 16, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants