Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create references only in string values in JSON templates #1672

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arthurpitman
Copy link
Contributor

This PR adds a feature that, when enabled via the MONACO_CREATE_REFS_IN_STRINGS feature flag, only creates references in string values within the JSON templates.

Copy link

github-actions bot commented Jan 16, 2025

Unit Test Results

1 987 tests  +15   1 986 ✅ +15   54s ⏱️ ±0s
  135 suites ± 0       1 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit dfaff8c. ± Comparison against base commit a928904.

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman self-assigned this Jan 17, 2025
@arthurpitman arthurpitman force-pushed the feat/create-references-in-string-values branch from baefffa to dfaff8c Compare January 17, 2025 15:34
@arthurpitman arthurpitman added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Jan 17, 2025
Copy link

E2E Test Results

    4 files  ± 0    272 suites  ±0   24m 33s ⏱️ + 2m 5s
2 106 tests +15  2 104 ✅ +15  2 💤 ±0  0 ❌ ±0 
2 258 runs  +15  2 256 ✅ +15  2 💤 ±0  0 ❌ ±0 

Results for commit dfaff8c. ± Comparison against base commit a928904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant