fix: Skip reference parameter creation if parameter is unused in template

[arthurpitman]

This PR ensures that no reference parameter is added to a config if the parameter is unused in the template.

Due to the way the code currently works, the fix is made in both dependency resolvers. This could maybe be improved in a follow up PR, however changes to this code have performance implications and thus should be measured.

A test is also added demonstrating the correct behavior.

In practice the simplest way to demonstrate it is to create a classic config with a name that occurs often in configs out of context. A good example is a network zone with the name _.

This string occurs often in templates however as a false positive, which is detected via a regex:

dynatrace-configuration-as-code/pkg/download/dependency_resolution/resolver/shared.go

Lines 69 to 82 in 3290212

	func replaceAll(content string, key string, s string) string {
	// The prefix and suffix we search for are alphanumerical, as well as the "-", and "_".
	// From investigating, this character set seems to be the most basic regex that still avoids false positive substring matches.
	str := fmt.Sprintf("([^a-zA-Z0-9_-])(%s)([^a-zA-Z0-9_-])", key)
	// replace only strings that are not part of another larger string. See testcases for exact in/out values.
	re, err := regexp.Compile(str)
	if err != nil {
	log.Debug("Failed to compile string %q to regex. Falling back to use simple string replace.", str)
	return strings.ReplaceAll(content, key, s)
	}
	return re.ReplaceAllString(content, fmt.Sprintf("$1%s$3", s))
	}

The simple fix here just checks if the replaceAll function actually changed the content of the template and if not, skips parameter creation.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Unit Test Results

1 966 tests  +2   1 965 ✅ +2   54s ⏱️ -1s
  135 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e2c707b. ± Comparison against base commit 3290212.

[github-actions]

E2E Test Results

    4 files   -   1    272 suites   - 135   24m 58s ⏱️ - 49m 58s
2 085 tests ±  0  2 083 ✅ ±  0  2 💤 ±0  0 ❌ ±0 
2 237 runs   - 152  2 235 ✅  - 152  2 💤 ±0  0 ❌ ±0 

Results for commit e2c707b. ± Comparison against base commit 3290212.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.

github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform

github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/dependency_resolution ‑ TestDependencyResolution/no_parameter_created_for_false_positive_BasicResolver
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/download/dependency_resolution ‑ TestDependencyResolution/no_parameter_created_for_false_positive_FastResolver

[jskelin]

LGTM