fix: Skip download of ready-made documents from apps #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpitman
added
the
run-e2e-test
E2E Test Results 4 files - 1 272 suites - 135 26m 26s ⏱️ - 54m 39s For more details on these failures, see this check. Results for commit 1fbc33f. ± Comparison against base commit a928904. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
arthurpitman
added
run-e2e-test
arthurpitman
added a commit
to Dynatrace/dynatrace-configuration-as-code-core
that referenced
this pull request
Jan 22, 2025
This PR adds `originAppId` to `documents.Metadata`, as needed for Dynatrace/dynatrace-configuration-as-code#1674
arthurpitman
force-pushed
the
fix/only-dowload-documents-without-origin-app-id
branch
from
1fbc33f to
609fa4d
Compare
arthurpitman
changed the title
arthurpitman
force-pushed
the
fix/only-dowload-documents-without-origin-app-id
branch
from
849964d to
843436f
Compare
arthurpitman
force-pushed
the
fix/only-dowload-documents-without-origin-app-id
branch
from
843436f to
43510ea
Compare
|
tomazpu
approved these changes
Jan 22, 2025
arthurpitman
deleted the
fix/only-dowload-documents-without-origin-app-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR only documents with no specified
originAppIdare downloaded, thus skipping the download of all "ready-made documents" for apps. This is important as these documents cannot be deployed.