-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align ProcessModuleConfig secret reconciler with other reconcilers #3991
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3991 +/- ##
==========================================
+ Coverage 64.58% 64.61% +0.02%
==========================================
Files 397 397
Lines 26416 26398 -18
==========================================
- Hits 17062 17056 -6
+ Misses 8028 8019 -9
+ Partials 1326 1323 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/controllers/dynakube/processmoduleconfigsecret/reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controllers/dynakube/processmoduleconfigsecret/reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controllers/dynakube/processmoduleconfigsecret/reconciler.go
Outdated
Show resolved
Hide resolved
7e059e2
to
bc48950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and works
Description
This PR refactors the process module config secret reconciler to use a Query object.
It as well aligns the structure with other reconcilers and adds a cleanup for the secret created.
Jira
How can this be tested?