Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ProcessModuleConfig secret reconciler with other reconcilers #3991

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Oct 25, 2024

Description

This PR refactors the process module config secret reconciler to use a Query object.
It as well aligns the structure with other reconcilers and adds a cleanup for the secret created.

Jira

How can this be tested?

  • Create a CloudNativeFullStack DynaKube and check if the pmc secret exists.
  • Check the conditions in the DynaKube for pmc as well

@gkrenn gkrenn added the core Changes to core functionality of the Operator label Oct 25, 2024
@gkrenn gkrenn requested a review from a team as a code owner October 25, 2024 10:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.61%. Comparing base (9d2972d) to head (bc48950).

Files with missing lines Patch % Lines
...s/dynakube/processmoduleconfigsecret/reconciler.go 90.00% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3991      +/-   ##
==========================================
+ Coverage   64.58%   64.61%   +0.02%     
==========================================
  Files         397      397              
  Lines       26416    26398      -18     
==========================================
- Hits        17062    17056       -6     
+ Misses       8028     8019       -9     
+ Partials     1326     1323       -3     
Flag Coverage Δ
unittests 64.61% <92.15%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants