update CPW loader to include 7day/hourly forecasts, warnings, sunrise… #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dukestep
force-pushed
the
add-7dayforecast-cpw
branch
3 times, most recently
from
704b550 to
0a3bb92
Compare
Dukestep
force-pushed
the
add-7dayforecast-cpw
branch
from
0a3bb92 to
0784315
Compare
Dukestep
force-pushed
the
add-7dayforecast-cpw
branch
from
0784315 to
6ca4343
Compare
Dukestep
force-pushed
the
add-7dayforecast-cpw
branch
2 times, most recently
from
07e7ebb to
6e5c458
Compare
|
Rebased on master and added in recent upstream changes made to the pygeoapi's Elasticsearch provider (see geopython/pygeoapi#1882 and geopython/pygeoapi#1887) to the @tomkralidis ready for review! |
Dukestep
force-pushed
the
add-7dayforecast-cpw
branch
from
6e5c458 to
269c586
Compare
Dukestep
force-pushed
the
add-7dayforecast-cpw
branch
from
269c586 to
78d01f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CPW realtime loader to also include the 7-day forecasts, hourly forecasts, warnings and sunrise/sunset times. It also implements a new document mapping meant to more closely resemble how the XML data is structured. See an example GeoJSON feature on geojson.io.
A custom provider (
msc_pygeoapi/provider/cpw_elasticsearch.py) was created to allow for better support of ElasticSearch nested fields (used here to contain an array of forecast objects) and GeoJSON properties with an object as a value. Additionally, support for querying nested fields was added when a OGC API Features query contains a value filter on a property back by an Elasticsearch nested field type.