Add ENABLE_BBAPI_FALLBACK, check FS type on BBAPI transfers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you attempted to copy a file using BBAPI, and either the source and destination didn't support file extents, then it would automatically fallback to using pthreads. This change removes the fallback by default, and returns an error instead. The fallback can be re-enabled by passing -DENABLE_BBAPI_FALLBACK to cmake. This patch also checks the source and destination filesystem type against a whitelist instead of checking if they support extents. This was more effective, as there were some filesystems that BBAPI could not copy to/from even though they supported extents.
|
This patch will help with LLNL/scr#163 |
|
Nice touch to make this an option. Thanks, @tonyhutter . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you attempted to copy a file using BBAPI, and either the source and destination didn't support file extents, then it would automatically fallback to using pthreads. This change removes
the fallback by default, and returns an error instead. The fallback can be re-enabled by passing -DENABLE_BBAPI_FALLBACK to cmake.
This patch also checks the source and destination filesystem type against a whitelist instead of checking if they support extents. This was more effective, as there were some filesystems that BBAPI could not copy to/from even though they supported extents.