WarpX class : current_centering_* variables no longer static #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucafedeli88
commented
Feb 5, 2025
| @@ -3043,10 +3043,10 @@ def initialize_inputs(self): | |||
| pywarpx.warpx.field_centering_noz = self.field_centering_order[-1] | |||
| # warpx.current_centering_no<x,y,z> | |||
| if self.current_centering_order is not None: | |||
| pywarpx.warpx.current_centering_nox = self.current_centering_order[0] | |||
| pywarpx.warpx.m_current_centering_nox = self.current_centering_order[0] | |||
There was a problem hiding this comment.
I am not too familiar with picmi: is it OK to make this change here?
There was a problem hiding this comment.
Good question. I'm not 100% sure.
I think these might need to match the names of the input parameters exposed to the users, i.e., the names set here without m_:
https://github.com/lucafedeli88/WarpX/blob/ce93182632c5cd43049e1111f3cd8976642e7aa2/Source/WarpX.cpp#L1073-L1078
utils::parser::queryWithParser(
pp_warpx, "current_centering_nox", m_current_centering_nox);
utils::parser::queryWithParser(
pp_warpx, "current_centering_noy", m_current_centering_noy);
utils::parser::queryWithParser(
pp_warpx, "current_centering_noz", m_current_centering_noz);@dpgrote
Can you confirm? I might be wrong, I'm not 100% sure.
lucafedeli88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the static variables of the WarpX class
current_centering_nox,current_centering_noy, andcurrent_centering_nozinto private member variables:m_current_centering_nox,m_current_centering_noy, andm_current_centering_noz.