-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cropping of particles at boundaries for deposition for charge conservation #5649
Open
dpgrote
wants to merge
13
commits into
ECP-WarpX:development
Choose a base branch
from
dpgrote:stop_particles_at_boundary
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cropping of particles at boundaries for deposition for charge conservation #5649
dpgrote
wants to merge
13
commits into
ECP-WarpX:development
from
dpgrote:stop_particles_at_boundary
+326
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only in Villasenor and Buneman current deposition in this commit
The cropping should not be applied at PMC (symmetry) boundaries. Only at physical boundaries like conductors and insulators. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the deposition (and field gather), cropping particle orbits at the boundary of the domain for PEC and PMC boundaries. This is a simple way of achieving charge conservation as particles are absorbed at boundaries.
Should this always be done or should a flag be added to turn this feature on?
Only in Villasenor and Buneman current deposition now. Will be extended to Esirkepov.
A second necessary change (with reflective boundaries) is to stop the particle orbits at the boundary so that in the next time step, the particles start at the boundary.