Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WarpX class: move WriteUsedInputsFile to an anonymous namespace in WarpXInitData.cpp #5657

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

WarpX class: move WriteUsedInputsFile to an anonymous namespace in WarpXInitData.cpp #5657

wants to merge 2 commits into from
+10 −14

Conversation

lucafedeli88
Copy link
Member

WriteUsedInputsFile is used only once in WarpXInitData.cpp. Therefore, this PR turns it from a method of the WarpX class to a simple function inside an anonymous namespace in WarpXInitData.cpp

@lucafedeli88 lucafedeli88 added the cleaning Clean code, improve readability label Feb 11, 2025
@ax3l ax3l self-requested a review February 19, 2025 00:55
@ax3l ax3l self-assigned this Feb 19, 2025
@ax3l
Copy link
Member

ax3l commented Feb 19, 2025

@lucafedeli88 thanks! Little rebase pls :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l Awaiting requested review from ax3l

At least 1 approving review is required to merge this pull request.

Assignees

@ax3l ax3l

Labels
cleaning Clean code, improve readability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucafedeli88 @ax3l