-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update constants to use values from CODATA2022 #5661
base: development
Are you sure you want to change the base?
Update constants to use values from CODATA2022 #5661
Conversation
Thanks, Dave. If there is a large number of benchmarks that need to be reset, this could be a good opportunity to test again our tool Tools/DevUtils/update_benchmarks_from_azure_output.py and its instructions in our documentation. In theory, I updated and tested the tool manually in #5372. However, it is not tested automatically yet. |
Thanks @EZoni ! It worked and was easy to do. BTW, to download the raw log file, I copied the URL from he location bar and pasted it into the Note that almost all of the changes in the benchmarks are small as expected, ~1.e-9 or smaller. One exception is the |
I agree. I think that test has relatively large tolerances anyways, if I remember correctly. @aeriforme, what do you think? |
Thanks for pointing this out! I added this hint to our documentation in #5663. |
…tion_psb analysis test
The values of the physical constants were from CODATA 2018. These should be updated to the current accepted values as specified in CODATA 2022.
This breaks many CI benchmarks since the checks are at a higher precision than the changes in the constants.
Note that scipy recently updated the constants to use CODATA 2022 (in version 1.15.0 on January 3). This may cause problems in the CI tests. However, we use Ubuntu 20.4 to run the tests, and there, the version of scipy is 1.3.3 which uses constants from CODATA 2014!
These CI tests needed to be updated.