Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PECInsulator to Curl-Curl BC #5667

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Feb 13, 2025

This is a temporary fix, setting a boundary condition for the Curl-Curl preconditioner for the implicit solver. This now sets the BC to Dirichlet for the PEC regions. A correct solution would have to be implemented in the curl-curl solver because of the split between the PEC and insulator sections.

Copy link
Member

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpgrote ! LGTM

@lucafedeli88 lucafedeli88 merged commit 072341c into ECP-WarpX:development Feb 18, 2025
37 checks passed
@dpgrote dpgrote deleted the fix_curlcurl_BC branch February 18, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants