-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommunicationPlan copy #295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
========================================
+ Coverage 93.4% 95.2% +1.8%
========================================
Files 50 50
Lines 2944 2952 +8
========================================
+ Hits 2750 2811 +61
+ Misses 194 141 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Updated to match arborx/ArborX#369 |
It looks like the codecov patch is failing because we're only running with one MPI rank on travis (and therefore not testing a reasonable fraction of the |
Try to set |
@junghans I added to Travis, but it didn't seem to change anything |
fixed |
@sslattery this is ready for re-review |
First, adding a test which fails in copying the
CommunicationPlan
due to duplicating communicators. Add missing copy constructor/assignment operator.Found during periodic communication #263 with @sslattery
Increased coverage by explicitly setting
MPI_EXEC_NUMPROCS=2
for travis (previously running everything one one rank)