feat: remove codesigning from github releases

EETagent · Feb 2, 2024 · 0aa85db · 0aa85db
1 parent a636116
commit 0aa85db
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,7 +11,7 @@ env:
   MACOS_DMG_ARTIFACT: "Send.dmg"
   MACOS_ZIP_ARTIFACT: "Send.zip"
   XCBUILD_PATH: "build/Build/Products/Release"
-  CODE_SIGN_IDENTITY: "Apple Development: [email protected] (JLHQ66WC7C)"
+  #CODE_SIGN_IDENTITY: "Apple Development: [email protected] (JLHQ66WC7C)"
 
 jobs:
   ReleaseCI:
@@ -56,21 +56,21 @@ jobs:
       with:
         xcode-version: latest
 
-    - name: Import Certificates 📜
-      uses: apple-actions/import-codesign-certs@v2
-      with:
-        p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
-        p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
+    # - name: Import Certificates 📜
+    #   uses: apple-actions/import-codesign-certs@v2
+    #   with:
+    #     p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
+    #     p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
 
     - name: Release Build 🔨
       run: |
         xcodebuild -scheme ${MACOS_APP_NAME} -configuration Release -derivedDataPath build -disableAutomaticPackageResolution CODE_SIGN_IDENTITY="${CODE_SIGN_IDENTITY}" | xcpretty && exit ${PIPESTATUS[0]}
 
-    - name: Resign app 🔑 (Temp fix for Sparkle updating)
-      run: codesign -f -s "${CODE_SIGN_IDENTITY}" "${XCBUILD_PATH}/${MACOS_APP_ARTIFACT}"
+    # - name: Resign app 🔑 (Temp fix for Sparkle updating)
+    #   run: codesign -f -s "${CODE_SIGN_IDENTITY}" "${XCBUILD_PATH}/${MACOS_APP_ARTIFACT}"
 
-    - name: Check Send signature 🔑
-      run: codesign --verify -vvvv --deep --strict "${XCBUILD_PATH}/${MACOS_APP_ARTIFACT}"
+    # - name: Check Send signature 🔑
+    #   run: codesign --verify -vvvv --deep --strict "${XCBUILD_PATH}/${MACOS_APP_ARTIFACT}"
 
     - name: Create Disk Image 💿
       run: |

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -20,11 +20,11 @@ jobs:
         with:
           xcode-version: latest
 
-      - name: Import Certificates 📜
-        uses: apple-actions/import-codesign-certs@v2
-        with:
-          p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
-          p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
+      # - name: Import Certificates 📜
+      #   uses: apple-actions/import-codesign-certs@v2
+      #   with:
+      #     p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
+      #     p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
 
       - name: Debug Build 🔨
-        run: xcodebuild -scheme Send -destination "platform=macOS" -configuration Debug CODE_SIGN_IDENTITY=- | xcpretty && exit ${PIPESTATUS[0]}
+        run: xcodebuild -scheme Send -destination "platform=macOS" -configuration Debug CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO | xcpretty && exit ${PIPESTATUS[0]}