Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Twitch JS API widget replacement placeholder #3050

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Twitch JS API widget replacement placeholder #3050

wants to merge 1 commit into from

Conversation

ghostwords
Copy link
Member

Example: https://gronkh.tv/live/GronkhTV

TODOs:

  • More examples, potentially more Twitch JS API functionality
  • Factor out webrequest.js widget message proxying into own file
  • MV3 implications? Maybe none?

@ghostwords ghostwords added widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets surrogates Replacement blank/noop/dummy/neutered versions of tracking scripts used to avoid site breakages labels Jan 30, 2025
ghostwords
ghostwords commented Jan 31, 2025
View reviewed changes
src/js/webrequest.js
let widget = {
name,
buttonSelectors: ["#" + dom_id],
scriptSelectors: [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need scriptSelectors if we're going to reloadOnActivation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
surrogates Replacement blank/noop/dummy/neutered versions of tracking scripts used to avoid site breakages widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghostwords