Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Light hook] Add support for Adaptive Lighting #115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KrzysztofHajdamowicz
Copy link

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.

Note: Remove this section if this PR is NOT a breaking change.

Proposed change*

Adaptive lighting is a great custom component enabling following sunlight by smart light sources (especially LED bulbs with variable color temperature).
Component itself listens for events like 'Light powered on', but there is slight delay between powering on light and adapting it to current environment. It is especially painful when You was in WC, let's say at 15:00 and you go there at 23:15- before light dims and warms there is a second or two, where Your eyes are attacked by intensive and cold light.

This PR solves this issue and enables bonding adaptive lighting with a hook, making light powered on with correct light flavour without delay. Solves #112

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

@github-actions
Copy link
Contributor

Hey @KrzysztofHajdamowicz, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution. ''
This comment keeps track of the status of your submission. We'll update this comment with progress regarding your changes, providing you guidance if additional actions need to be performed before your contribution is reviewed and merged.

Results are coming soon, stay tuned!

@KrzysztofHajdamowicz
Copy link
Author

Hello, I rebased this PR to align it with current main

Repository owner deleted a comment from github-actions bot Nov 21, 2021
Repository owner deleted a comment from github-actions bot Nov 21, 2021
@EPMatt
Copy link
Owner

EPMatt commented Nov 21, 2021

Hi @KrzysztofHajdamowicz, thank you so much for your contribution! 🚀

I'm sorry for my long delay in answering. I'll take a deeper look at the Adaptive Lighting integration to see what features it offers, I'll then report back here with my thoughts about this PR. For now I've just pushed an update to trigger automated checks here on GitHub, to make sure everything is great with your submission.

Thanks again! I really appreciate the time and effort you put into this. :)

@KrzysztofHajdamowicz
Copy link
Author

Thanks for merging! I'm testing this integration for a few months, works flawlessly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants