Add two utility functions to HighsDomain.cpp #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into neos4LargeBnds # Conflicts: # src/mip/HighsDomain.cpp
jajhall
approved these changes
Jun 1, 2024
|
I only tested on a handful of instances so far. I hope to have the full results by the end of next week, if that's OK. |
fwesselm
commented
Jun 18, 2024
| accept = true; | ||
| else | ||
| accept = false; | ||
| bound = static_cast<double>(floor(boundVal + mipsolver->mipdata_->feastol)); |
There was a problem hiding this comment.
Floor is now computed (using HighsCDouble) before casting back to double. This causes a behavior change on 7 out of 854 problems that I tested.
fwesselm
commented
Jun 18, 2024
| accept = true; | ||
| else | ||
| accept = false; | ||
| bound = static_cast<double>(ceil(boundVal - mipsolver->mipdata_->feastol)); |
There was a problem hiding this comment.
Ceiling is now computed (using HighsCDouble) before casting back to double. This causes a behavior change on 7 out of 854 problems that I tested.
|
Test results show that HiGHS' behavior is affected on problems neos-1605075, neos-619167, neos-693347, noswot, ns1685374, pigeon-10 and rocI-4-11 (see comments above). Other than that performance is identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two small utility functions to
src/mip/HighsDomain.cppto remove identical code blocks:computeDeltafor computing change in bounds on constraint activitiesboundRangefor computing the bound range.I also fixed some typos along the way.