Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1908 #1909

Merged
merged 14 commits into from
Sep 9, 2024
Merged

Fix 1908 #1909

merged 14 commits into from
Sep 9, 2024

Conversation

jajhall
Copy link
Member

@jajhall jajhall commented Sep 4, 2024

Run clang formatting

@jajhall
Copy link
Member Author

jajhall commented Sep 4, 2024

@fwesselm There were some changes when I ran clang formatting locally. However, there does seem to be an error in the clang format test on GitHub.

@galabovaa Please would you look into this

Looking again, maybe it's a consequence of updating my Ubuntu version. My clang version may have changed

@fwesselm
Copy link
Contributor

fwesselm commented Sep 9, 2024

@jajhall I also saw that there were changes when I ran the clang formatting. The test-clang-format now seems to run fine again in my branch. If you like, I could create another pull request.

@jajhall
Copy link
Member Author

jajhall commented Sep 9, 2024

So, I've run clang-format on my desktop running Ubuntu 22.04 (and clang-format 14.0.0-1ubuntu1.1), and the test-clang-format CI tests work OK

I've got stuff to push from my laptop running Ubuntu 24.04 (and clang-format 18.1.3 (1ubuntu1)) and will see whether the test-clang-format CI tests work OK

@jajhall jajhall merged commit 0f31d20 into latest Sep 9, 2024
250 checks passed
@jajhall jajhall deleted the fix-1908 branch September 9, 2024 17:47
@jajhall
Copy link
Member Author

jajhall commented Sep 9, 2024

Fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants