Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update highspy bindings and cleanup meson.build for SciPy #2005

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

HaoZeke
Copy link
Contributor

@HaoZeke HaoZeke commented Oct 28, 2024

One part of #1987. Basically after #1997 there are still some more warnings needed for SciPy to be happy scipy/scipy#21565; but that'll be in a follow up as per @galabovaa 's suggestion #1987 (comment) and.

The changes here are (as seen in each commit message, summarized here):

  • Fixes to remove unused variables within highs_bindings.cpp
    • Also cleaned up the export_values situation with a code comment
  • Adding enums used by SciPy but not currently present in highspy:
    • HighsDebugLevel
    • SimplexCrashStrategy
  • Removed HighsOptionsManager, which I added explicitly for the SciPy bindings
    • It isn't used by highspy internally, so should live in scipy anyway

The only other changes (not really enumerated) are those to the meson.build; and are essentially just to keep the built libraries up to date and compatible with SciPy.

Next steps:

Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for the Meson build changes to be made, as this is no longer supported by HiGHS

In src/highs_bindings.cpp, I'd like @mathgeekcoder to review the removal of data from highs_setCallback.

The code to make enum SimplexCrashStrategy available to highspy should be removed, as there is no longer any code in HiGHS for a simplex crash strategy. I'll delete it from lp_data/SimplexConst.h - which, I believe, doesn't need to be included, since the values of enum SimplexEdgeWeightStrategy were obtained via #include "Highs.h"

@mathgeekcoder
Copy link
Contributor

In src/highs_bindings.cpp, I'd like @mathgeekcoder to review the removal of data from highs_setCallback.

Thanks Julian. The change to setCallback looks good to me!

@galabovaa galabovaa merged commit a8b5cc6 into ERGO-Code:latest Oct 29, 2024
110 checks passed
HaoZeke added a commit to HaoZeke/scipy that referenced this pull request Oct 31, 2024
As noted by @jajhall, these no longer do anything within HiGHS [1]

[1] ERGO-Code/HiGHS#2005 (review)
HaoZeke added a commit to HaoZeke/scipy that referenced this pull request Nov 10, 2024
As noted by @jajhall, these no longer do anything within HiGHS [1]

[1] ERGO-Code/HiGHS#2005 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants