Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute primal-dual integral #2014

Merged
merged 30 commits into from
Nov 6, 2024
Merged

Compute primal-dual integral #2014

merged 30 commits into from
Nov 6, 2024

Conversation

jajhall
Copy link
Member

@jajhall jajhall commented Oct 29, 2024

Although ctest passes, there is still an assert 333 == 999 corresponding to new code not tested.

There is also plenty of debug printing to remove.

@jajhall
Set up HighsPrimaDualIntegral struct in HighsMipSolverData.h
831c372
@jajhall
Written HighsMipSolverData::updatePrimaDualIntegral
ca73d50
@jajhall
Putting in checks for lower bound changes
3a33183
@jajhall
Need to save the bounds with shifts
045f8a5
@jajhall
Now ready to switch what's stored in updatePrimaDualIntegral
72c94fe
@jajhall
Still not right for bell5 after restart
2037b98
@jajhall
P-D integral for bell5 now OK; Add check gap change assert to updateP…
3a1f468 
…rimaDualIntegral
@jajhall
Added gap change checking and computing P-D integral using fractional…
d40dce0 
… gap not percentage
@jajhall
Now use pdi.value = -kHighsInf as flag for updatePrimaDualIntegral no…
454ef29 
…t previously called
@jajhall
flugpl works again with full bound change tracking!
f41d567
@jajhall
Check bound_change on tolerance of 0
3371d97
@jajhall
Check bound_change on tolerance of 0
b5f3fbe
@jajhall
capi_unit_test passes
c7a4883
@jajhall
Need to check to/from_lower/upper_bound differences when bound_change…
59ff05d 
… false
@jajhall
Merge branch 'latest' into fix-1946
b06cba8
@jajhall
Added Highs_getDualUnboundednessDirection to C API, and added primal_…
f14b4ea 
…dual_integral to HighsInfo
@jajhall
Move to markov
8c80b33
@jajhall
Unit tests pass
4285c86
@jajhall
ctest passes; formatted
1cea261
@jajhall jajhall mentioned this pull request Oct 29, 2024
Closed
@jajhall jajhall marked this pull request as ready for review November 6, 2024 12:29
@jajhall jajhall merged commit c45de5b into latest Nov 6, 2024
244 checks passed
@jajhall jajhall deleted the fix-1946 branch November 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jajhall