Implement parcel_hscale as a namelist parameter in ZM deep convection scheme #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s):
@swrneale
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
From issue #203 "Change the 'parcel_hscale' parameter in the ZM convection (zm_conv_intr.F90) to a namelist parameter"
This PR is needed in parallel with ESCOMP/cam PR# 1266
List all namelist files that were added or changed:
zmconv/atm_in
List all files eliminated and why:
None
List all files added and what they do:
None
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)zm_convr.F90:
Transfer new namelist variables from the zm_conv_intr.F90 (ESCOMP/CAM) through namelist read code and to be used in zm_convr.F90
List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
No
If yes to the above question, describe how this code was validated with the new/modified features: