Move fiona to be installed from conda forge #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just checked and this PR fixed this issue mentioned above. Thanks for looking into this @valeriupredoi 👍 |
|
brilliant, cheers Remi! can you pls approve so we get it merged and cherrypicked in the release? 🍺 |
remi-kazeroni
approved these changes
Feb 8, 2021
bouweandela
reviewed
Feb 8, 2021
| @@ -32,9 +32,6 @@ | |||
| 'install': [ | |||
| 'cf-units', | |||
| 'dask[array]', | |||
| # fiona: 1.8.18/py39, they seem weary to build manylinux wheels | |||
| # so we may have to install from conda-forge in the future | |||
| 'fiona', | |||
There was a problem hiding this comment.
The list in setup.py lists all dependencies, regardless of how they're installed. Could you put fiona back here @valeriupredoi? If it's installed by conda already, pip won't try to install it.
There was a problem hiding this comment.
aha will do now!
There was a problem hiding this comment.
#990 pls approve so we merge and release the fiona baby
There was a problem hiding this comment.
cheers for pointing out and reviewing, bud!
jvegreg
pushed a commit
that referenced
this pull request
Feb 9, 2021
* added fiona as dep * removed fiona as pypi dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fionais again giving us headaches, the reason why I am moving it to be aconda-forgedependency instead of PyPi is in this comment as a result of @remi-kazeroni noticing fiona trying to read an old csv file from GDAL that has disappeared from GDAL>=3.1 and asking us about it in this comment, also an issue documented here Toblerity/Fiona#897 (towards the bottom)