Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce orleans module #44

Merged
merged 7 commits into from
Sep 17, 2022
Merged

Introduce orleans module #44

merged 7 commits into from
Sep 17, 2022

Conversation

RayMMond
Copy link
Member

@RayMMond RayMMond commented Sep 6, 2022

Resolve #34

@RayMMond RayMMond requested a review from gdlcf88 September 10, 2022 05:56
Copy link
Member

@gdlcf88 gdlcf88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current design is generally LGTM. Could you please create some UTs for the new module?

@RayMMond RayMMond requested a review from gdlcf88 September 16, 2022 10:24
@gdlcf88
Copy link
Member

gdlcf88 commented Sep 17, 2022

I'm merging this PR and looking forward to the related documentation. #23

@gdlcf88 gdlcf88 merged commit 7863fd6 into main Sep 17, 2022
@gdlcf88 gdlcf88 deleted the orleans-module branch September 17, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Orleans as AssetOccpuancyProvider
2 participants