Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge typing of expressions and formulas #671

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Merge typing of expressions and formulas #671

merged 1 commit into from
Dec 19, 2024

Conversation

strub
Copy link
Member

@strub strub commented Dec 16, 2024

No description provided.

@strub strub self-assigned this Dec 16, 2024
@strub strub force-pushed the remove-expr-typing branch from d2f69ec to 9d716f0 Compare December 16, 2024 09:07
This is a step forward removing expressions from EasyCrypt.

This commit removes all parsing and typing code specific to
expressions. Expressions are now parsed as formulas, utilizing the
formula type checker instead of an expression-specific type
checker. If a formula does not represent a valid expression, it is the
type checker's responsibility to raise a meaningful error message.
@strub strub force-pushed the remove-expr-typing branch from 9d716f0 to ec01f8d Compare December 18, 2024 07:13
@strub strub changed the title merge typing of expressions and formulas Merge typing of expressions and formulas Dec 18, 2024
@strub strub requested a review from bgregoir December 18, 2024 07:14
@strub strub added the chore Ungrateful tasks that need done but that nobody wants to do label Dec 18, 2024
@strub strub marked this pull request as ready for review December 18, 2024 07:14
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clearly simplify...

src/ecParser.mly Show resolved Hide resolved
src/ecParsetree.ml Show resolved Hide resolved
src/ecTyping.ml Show resolved Hide resolved
@strub strub merged commit 13acf05 into main Dec 19, 2024
15 checks passed
@strub strub deleted the remove-expr-typing branch December 19, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Ungrateful tasks that need done but that nobody wants to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants