Rework import mechanism #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed all ad-hoc mechanisms, clean-up general one, correct interaction with cloning. Yet has to be extended => future PR. |
strub
force-pushed
the
hidden-theory-items
branch
from
19e8269 to
fdd7813
Compare
The import mechanism is currently brittle, buggy, interact wrongly with the cloning mechanism. Moreover, some declarations duplicate it by reimplementing an ad-hoc, "non-import" mechanism. This commit fixes this issues.
strub
force-pushed
the
hidden-theory-items
branch
from
fdd7813 to
fa18670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import mechanism is currently brittle, buggy, interact wrongly with the cloning mechanism. Moreover, some declarations duplicate it by reimplementing an ad-hoc, "non-import" mechanism.