Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open_in_new icon #1590

Merged
merged 2 commits into from
Jan 24, 2025
Merged

feat: add open_in_new icon #1590

merged 2 commits into from
Jan 24, 2025

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jan 24, 2025

πŸ“ Changes

New icon, who dis?

Screenshot 2025-01-24 at 4 14 34β€―PM

βœ… Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

Copy link
Member

@OskiTheCoder OskiTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Justintime50 Justintime50 merged commit 0b80019 into main Jan 24, 2025
5 checks passed
@Justintime50 Justintime50 deleted the open_in_new_icon branch January 24, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants