Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Include "verify" and "verify_strict" parameters for Address creation #582

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

nwithan8
Copy link
Contributor

Description

Include Verify and VerifyStrict parameters for Address when creating as part of Shipment et. al creation request.

These were previously purposefully excluded when Address creation was being performed as part of a larger creation request, such as Shipment or Order, due to uncertainty about their placement in the payload schema. Consequently, this made for end-user confusion as to why address verification was not being performed as part of a Shipment or Order creation, and was causing Shipments and Orders to be successfully created with invalid Addresses.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

…eating as part of Shipment et. al creation request
@nwithan8 nwithan8 requested a review from a team August 12, 2024 21:48
@nwithan8 nwithan8 merged commit 4717de3 into master Aug 13, 2024
14 checks passed
@nwithan8 nwithan8 deleted the address_verification branch August 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants