Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional webhook params #607

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Feb 14, 2025

Description

To the next dev that picks this up, we need to:

  1. Add the custom_headers to the create and update parameter sets
  2. Ensure that the update webhook overload function that uses the param sets doesn't need to have the params wrapped for it to work as expected
  3. Update create/update webhook tests to pass in the webhook_secret and custom_headers to ensure we pass them correctly

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant