Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extra webhook params #343

Merged
merged 23 commits into from
Feb 21, 2025
Merged

test: extra webhook params #343

merged 23 commits into from
Feb 21, 2025

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Feb 14, 2025

Description

  • Adds WebhookCustomHeader model, allowing custom_headers to be passed when creating/updating a webhook
  • Corrects payload wrapping for updating a webhook
  • Bumps dependencies

Testing

  • Tests new webhook params

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 marked this pull request as ready for review February 20, 2025 17:00
@Justintime50 Justintime50 requested a review from a team as a code owner February 20, 2025 17:00
Copy link

@keheitz keheitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Justintime50 Justintime50 merged commit 663a19a into master Feb 21, 2025
21 checks passed
@Justintime50 Justintime50 deleted the webhook_params branch February 21, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants