Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destiny Patch support #3131
Destiny Patch support #3131
Changes from 8 commits
d94557b
401582d
9695f59
7e23f12
b59b5a7
c6c1f56
a412d0d
252195a
c677c70
b4285ea
c079b72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 238 in src/game_destiny.cpp
GitHub Actions / ubuntu:22.04
Check failure on line 238 in src/game_destiny.cpp
GitHub Actions / debian:12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strcpy_s
is a Microsoft extension.In general you do not need
new
ormalloc
in modern C++ code. You could just change the type of_destinyScript
tostd::string
and dodestinyScript = code
.You can still do the
_scriptPtr
stuff via_scriptPtr = &destintyScript.data()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this
_scriptPtr
assignment is legal here because_destinyScript
is a member variable. (in case of a local variable this would return a dangling pointer because the memory is freed)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'll push again to see whether the code passes.