-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttyp0 changes (remove Thai and Hebrew), generator fix #3240
Conversation
Thanks for the fixes. Imo the new |
Okay this triggers now all that want the D and the E And we cannot move all upper letters by one to the right, this will look bad in other situations. This doesn't look solvable without redoing the font... So lets just undo this part. |
8bf89c9
to
7e4c89b
Compare
I've removed the change of the F letter, reverted the original version. |
I've checked, the PR doesn't change Shinonome (the case when Ruby version influences the final file, because of encoding issue), so it can be merged (I hope) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just one question, why is thai bin
and the rest bit
, possible typo?
7e4c89b
to
4824021
Compare
Renamed |
This PR does the following changes:
ttyp0: moves the letter F left 1px, to make sure it lines up in menus (requested in the chat),src/generated
, not insrc
)I'm not sure about the F change. The previous version looked better in running text (but worse in menus), the new version looks better in menus (but worse in running text). Here's before and after: